[ 
https://issues.apache.org/jira/browse/THRIFT-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639611#action_12639611
 ] 

Mark Slee commented on THRIFT-169:
----------------------------------

Looks good to me. I added in some comments to explain the order of operations 
for future reference.

Committed revision 704710.


> Buffered transports leave data in write buffer on failed flush
> --------------------------------------------------------------
>
>                 Key: THRIFT-169
>                 URL: https://issues.apache.org/jira/browse/THRIFT-169
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (PHP)
>            Reporter: Erik Frey
>            Priority: Minor
>         Attachments: buffered_flush_fix_php.patch
>
>
> When TBuffered/TFramedTransport's underlying transport fails during a 
> flush(), the transport enters an irrecoverable state with unflushed data in 
> its write buffer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to