[
https://issues.apache.org/jira/browse/THRIFT-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640904#action_12640904
]
Bryan Duxbury commented on THRIFT-178:
--------------------------------------
This seems cool. I almost think this should be the default for the java
generation, since I would imagine very few users derive more classes from the
generated Thrift structs.
I think the patch looks pretty good, at least the java implementation stuff. I
don't have much input about the lexer/parser/c++ stuff.
> Final Keyword
> -------------
>
> Key: THRIFT-178
> URL: https://issues.apache.org/jira/browse/THRIFT-178
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (C++), Compiler (General), Compiler (Java)
> Reporter: Erik Frey
> Priority: Minor
> Attachments: keyword_final_cpp_java.patch
>
>
> This introduces support for the final keyword in the thrift IDL. A C++
> thrift struct that is declared final loses it's virtual dtor, which saves the
> memory overhead of one vtable per instance. This (along with the required
> keyword) can be very helpful if you're passing around big lists of small
> thrift structs.
> This patch also includes modifications for the java generator to recognize
> and apply final. I'm not familiar enough with the other languages to know if
> this notion applies to them.
> (A patch for this was submitted in thrift's pre-apache days and was met with
> approval, but then fell off the radar, so I'm trying again.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
