[ 
https://issues.apache.org/jira/browse/THRIFT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Piotr Kozikowski updated THRIFT-222:
------------------------------------

    Attachment: thrift-222-v2.patch

Here is a second patch with code cleaned up a bit. I removed entirely the part 
that checks for "nocamel_style_" since the thrift documentation defines nocamel 
as "Do not use CamelCase field accessors with beans", and I'm not producing 
accessors here. There are a number of other methods such as toString and 
setFieldValue that also ignore nocamel.

If you still would like to see the nocamel_check throughout the code refactored 
as a method I think it deserves its own issue, as it doesn't really have 
anything to do with this one.

> Should have a reflection feature to know if the field corresponding to a 
> field id is set
> ----------------------------------------------------------------------------------------
>
>                 Key: THRIFT-222
>                 URL: https://issues.apache.org/jira/browse/THRIFT-222
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>            Reporter: Nathan Marz
>            Assignee: Piotr Kozikowski
>         Attachments: thrift-222-v2.patch, thrift-222.patch
>
>
> The closest thing to this now is "getFieldValue(int field)", but this only 
> provides the desired behavior for nullable fields since it delegates to the 
> getters for each field.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to