[
https://issues.apache.org/jira/browse/THRIFT-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661350#action_12661350
]
Kevin Clark commented on THRIFT-189:
------------------------------------
This looks fine, but we should probably just go all the way to the generated
route used in THRIFT-246.
> Speed up Ruby struct constructors some more
> -------------------------------------------
>
> Key: THRIFT-189
> URL: https://issues.apache.org/jira/browse/THRIFT-189
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Trivial
> Attachments: thrift-189.patch
>
>
> Right now, we depend on runtime calculation of a few mappings - default
> values and field names to ids. This is an improvement over how it used to
> work, but still slow, because of the creation time and access pattern of
> these mappings. The mappings should clearly be an output of the code
> generation phase, and would allow us to greatly simplify how we access the
> values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.