[
https://issues.apache.org/jira/browse/THRIFT-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666072#action_12666072
]
Ben Maurer commented on THRIFT-110:
-----------------------------------
{quote}Well, at first I just used the TField directly. However, the generated
struct serialization code reuses the TField objects, so if I don't copy them,
nothing works.{quote}
Right, I mean that you should re-use the TFields that you create on your own
after you pop them. The issue here is that Java effectively creates a
TField*[], whereas if we were writing efficient java code we'd have TFIeld[] so
that we didn't keep on malloc/freeing things. You can simulate that by having a
TField*[] but not freeing the object when you pop it, then reusing it the next
time you want a push.
There should be a benchmark to see if this stuff matters.
{quote}Hm, true, but the alternative is copying the object before returning it,
and it's unlikely the caller is going to modify it. We should probably just
make the fields on TField final. {quote}
You said "However, the generated struct serialization code reuses the TField
objects". I think that might preclude making things final :-)
> A more compact format
> ----------------------
>
> Key: THRIFT-110
> URL: https://issues.apache.org/jira/browse/THRIFT-110
> Project: Thrift
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: compact-proto-spec-2.txt, compact_proto_spec.txt,
> compact_proto_spec.txt, thrift-110-v2.patch, thrift-110-v3.patch,
> thrift-110-v4.patch, thrift-110-v5.patch, thrift-110-v6.patch,
> thrift-110.patch
>
>
> Thrift is not very compact in writing out data as (say protobuf) . It does
> not have the concept of variable length integers and various other
> optimizations possible . In Solr we use a lot of such optimizations to make a
> very compact payload. Thrift has a lot common with that format.
> It is all done in a single class
> http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/common/util/NamedListCodec.java?revision=685640&view=markup
> The other optimizations include writing type/value in same byte, very fast
> writes of Strings, externalizable strings etc
> We could use a thrift format for non-java clients and I would like to see it
> as compact as the current java version
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
