[
https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669103#action_12669103
]
David Reiss commented on THRIFT-126:
------------------------------------
Eugene Letuchy believed the "You can reply to this email to add a comment to
the issue online." message sent by JIRA, and sent the following comments to the
list.
Looks pretty good to me too. My quibbles:
- Should export new_transport_factory/1 for parity with other transports.
- This may be a micro-optimization, but I think a binary representation for
the buffer might be more efficient: per
http://erlang.org/doc/efficiency_guide/binaryhandling.html#4, appending to the
back of a binary is optimized in R12B to avoid a copy. The benefit of the IO
list on the wire is clear, but since this is an in-memory buffer, we don't get
the savings of avoiding io_list_to_binary, but do pay the cost of additional
cons cells for the intermediate io-list.
I've implemented #1 in the revised patch. I'm going to punt on #2 for now
since this module is only used for test cases so far.
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch,
> 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
>
>
> TMemoryBuffer is really helpful for testing protocol changes. I just
> implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
