[ 
https://issues.apache.org/jira/browse/THRIFT-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669130#action_12669130
 ] 

David Reiss commented on THRIFT-297:
------------------------------------

I think the sparseness is nice, but I don't think it is a critical feature.  
(It was meant primarily to allow graceful addition of new fields.)  What code 
would be duplicated?  I'm looking at the "Simple getter" and "Simple setter" in 
generate_java_bean_boilerplate.  I don't think it would be necessary to 
automatically update __isset in the generic setter in non-beans code.

> getFieldValue and setFieldValue should be abstract TBase methods
> ----------------------------------------------------------------
>
>                 Key: THRIFT-297
>                 URL: https://issues.apache.org/jira/browse/THRIFT-297
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java), Library (Java)
>            Reporter: Nathan Marz
>
> Since these methods can be called on every TBase instance, they should be 
> part of the TBase API. These methods are useful in conjunction with the meta 
> data features.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to