Do you think that's necessary? I *really* don't like editing history for two reasons. First, I think that it violates the expectation that the repository maintains an accurate history of all of the information in it (log messages are not versioned). Second, if someone uses an external tool that caches log messages, they get different results depending on what point they pulled the information from the server. The only time I've used this feature was when I accidentally referred to the wrong issue number, which is really damaging because it makes it impossible to find the context of the change. A cursory look at the Python test client and C++ test server reveals the purpose of this change, so I strongly prefer not to change it. The commit message was in the patch posted to JIRA and approved by another committer.
--David Greg Stein wrote: > Alrighty. Note that you can edit that log message with: svn pe svn:log > --revprop -r 739629 > > Maybe saying something like "respond with the provided error message > -- the python client tests for this response." ... or something like > that. > > Cheers, > -g > > On Sat, Jan 31, 2009 at 22:48, David Reiss <[email protected]> wrote: >> Sorry for being a bit vague. The python test client expects the error >> message >> to be whatever was passed as the argument, so prior to this patch, it was >> impossible to successfully run the python test client against the C++ test >> server. >> >> Greg Stein wrote: >>> Hunh? I don't see how that log message corresponds to the actual change. >>> >>> ?? >>> >>> On Sat, Jan 31, 2009 at 22:39, <[email protected]> wrote: >>>> Author: dreiss >>>> Date: Sat Jan 31 21:39:11 2009 >>>> New Revision: 739629 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=739629&view=rev >>>> Log: >>>> cpp: Make the test server compatible with the Python test client >>>> >>>> Modified: >>>> incubator/thrift/trunk/test/cpp/src/TestServer.cpp >>>> >>>> Modified: incubator/thrift/trunk/test/cpp/src/TestServer.cpp >>>> URL: >>>> http://svn.apache.org/viewvc/incubator/thrift/trunk/test/cpp/src/TestServer.cpp?rev=739629&r1=739628&r2=739629&view=diff >>>> ============================================================================== >>>> --- incubator/thrift/trunk/test/cpp/src/TestServer.cpp (original) >>>> +++ incubator/thrift/trunk/test/cpp/src/TestServer.cpp Sat Jan 31 21:39:11 >>>> 2009 >>>> @@ -229,7 +229,7 @@ >>>> if (arg.compare("Xception") == 0) { >>>> Xception e; >>>> e.errorCode = 1001; >>>> - e.message = "This is an Xception"; >>>> + e.message = arg; >>>> throw e; >>>> } else if (arg.compare("ApplicationException") == 0) { >>>> facebook::thrift::TException e; >>>> >>>> >>>>
