[
https://issues.apache.org/jira/browse/THRIFT-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670866#action_12670866
]
larryhastings edited comment on THRIFT-110 at 2/5/09 1:03 PM:
---------------------------------------------------------------
I gather my suggestions are irrelevant if you're simply not going to change the
compiler. That's fine--and we might as well stop discussing them and save
everyone's time.
| What does this accomplish? Leaving extra room for more types in the future?
The current formulation of the protocol leaves 3 open type spots, [...]
Yes, this accomplishes leaving extra room for more types in the future, as my
proposed alternate protocol left zero open type slots. If you won't ever need
to support new types you could certainly leave it undefined, or at the very
least unimplemented. (Me, I'm always afraid I've forgotten something, so I
always leave myself an out.)
Cheers,
/larry/
was (Author: larryhastings):
I gather my suggestions are irrelevant if you're simply not going to change
the compiler. That's fine--and we might as well stop discussing them and save
everyone's time.
| What does this accomplish? Leaving extra room for more types in the future?
The current formulation of the protocol leaves 3 open type spots, [...]
Yes, this accomplishes leaving extra room for more types in the future, as my
proposed alternate protocol left zero open type slots. If you won't ever need
to support new types you could certainly leave it undefined, or at the very
least unimplemented. (Me, I'm always afraid I've forgotten something, so I
always leave myself an out.)
Cheers,
/larry/
> A more compact format
> ----------------------
>
> Key: THRIFT-110
> URL: https://issues.apache.org/jira/browse/THRIFT-110
> Project: Thrift
> Issue Type: Improvement
> Reporter: Noble Paul
> Assignee: Bryan Duxbury
> Attachments: compact-proto-spec-2.txt, compact_proto_spec.txt,
> compact_proto_spec.txt, thrift-110-v2.patch, thrift-110-v3.patch,
> thrift-110-v4.patch, thrift-110-v5.patch, thrift-110-v6.patch,
> thrift-110-v7.patch, thrift-110-v8.patch, thrift-110-v9.patch,
> thrift-110.patch
>
>
> Thrift is not very compact in writing out data as (say protobuf) . It does
> not have the concept of variable length integers and various other
> optimizations possible . In Solr we use a lot of such optimizations to make a
> very compact payload. Thrift has a lot common with that format.
> It is all done in a single class
> http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/common/util/NamedListCodec.java?revision=685640&view=markup
> The other optimizations include writing type/value in same byte, very fast
> writes of Strings, externalizable strings etc
> We could use a thrift format for non-java clients and I would like to see it
> as compact as the current java version
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
