[
https://issues.apache.org/jira/browse/THRIFT-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673774#action_12673774
]
Ben Maurer commented on THRIFT-301:
-----------------------------------
This is an API change which is somewhat nasty to port in an existing code base
(you don't want to look at all read() calls, and there's no compiler to tell
you when you're wrong). The other changes listed were generally easier to fix
for users.
I don't have any objection to having a factory for classes (in fact, I think
it'd be a good feature).
> Turn read() into a class method
> -------------------------------
>
> Key: THRIFT-301
> URL: https://issues.apache.org/jira/browse/THRIFT-301
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Python), Library (Python)
> Reporter: Esteve Fernandez
> Attachments: thrift-301.patch, thrift-301_v2.patch,
> thrift-301_v3.patch, thrift-301_v4.patch, thrift-301_v5.patch,
> thrift-301_v6.patch
>
>
> Currently, the read() method is bound to each instance, but this makes
> impossible to make structures immutable (see THRIFT-162). The following patch
> changes the compiler to generate a class-bound read() method, it also updates
> the fastbinary extension accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
