[ 
https://issues.apache.org/jira/browse/THRIFT-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carlos Valiente updated THRIFT-282:
-----------------------------------

    Attachment: THRIFT-282.diff

bq.It looks like you're not putting newlines between each attribute if they 
don't have doc text. There is at least one other similar bug (for functions).

Fixed.

bq.Also, it looks like you don't generate a doctext for structures if 
individual fields have doctext, but the structure does not. Is this intentional?

Fixed (both for structures and functions).

bq.Why do you sort the fields by key instead of leaving them in IDL order?

I thought it made it easier to read the documentation. I've reverted that in 
the new patch: After all, there are probably not that many fields in an average 
struct definition.

> Emit Python docstrings
> ----------------------
>
>                 Key: THRIFT-282
>                 URL: https://issues.apache.org/jira/browse/THRIFT-282
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python)
>    Affects Versions: 0.1
>            Reporter: Carlos Valiente
>            Priority: Trivial
>             Fix For: 0.1
>
>         Attachments: THRIFT-282.diff, THRIFT-282.diff
>
>
> This patch makes the Python compiler emit docstrings for Thrift structs, 
> enums, services and service methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to