[ 
https://issues.apache.org/jira/browse/THRIFT-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Spiridon Eliopoulos updated THRIFT-399:
---------------------------------------

    Attachment: 0001-THRIFT-399.-haskell-Fixed-bugs-in-render_const_valu.patch

> Fix set and number issues in generated constant code
> ----------------------------------------------------
>
>                 Key: THRIFT-399
>                 URL: https://issues.apache.org/jira/browse/THRIFT-399
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Haskell)
>            Reporter: Spiridon Eliopoulos
>            Assignee: Spiridon Eliopoulos
>         Attachments: 
> 0001-THRIFT-399.-haskell-Fixed-bugs-in-render_const_valu.patch
>
>
> The compiler generates incorrect code for set constants. 
> First, the function "mkSet" (which does not exist) is being called on a list 
> of constants to make the set. "Set.fromList" should be used in place of 
> "mkSet". Second, no commas appear in the generated list, so all the values 
> are getting smushed together, which is likely to cause syntax errors in the 
> generated code if the constants are anything but numbers. Third, no type 
> annotations were being generated for the constants, which means that number 
> literals were being assigned a type of Integer rather than Int or Int64.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to