[
https://issues.apache.org/jira/browse/THRIFT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693795#action_12693795
]
Eugene Letuchy commented on THRIFT-127:
---------------------------------------
The patch is fine. Two minor quibbles:
1/ I'd rename _Else3 to _Else2 (or just _).
2/ The message "Skipping fid ~p", just after the diff'd portion, needs to be
sync'ed with "Skipping field ~p" and should likely have a reason provided as
part of the message.
> Erlang assumes that field types are correct and de-synchronizes if they are
> not
> -------------------------------------------------------------------------------
>
> Key: THRIFT-127
> URL: https://issues.apache.org/jira/browse/THRIFT-127
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments:
> 0002-THRIFT-127.-erl-Skip-fields-that-have-the-wrong-typ.patch
>
>
> Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
