[ 
https://issues.apache.org/jira/browse/THRIFT-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693930#action_12693930
 ] 

David Reiss commented on THRIFT-236:
------------------------------------

So is this resolved now, or are there still cases where Ruby serializes in 
hash-order?  And what about sets and maps?

> Structs should be serialized in a consistent order
> --------------------------------------------------
>
>                 Key: THRIFT-236
>                 URL: https://issues.apache.org/jira/browse/THRIFT-236
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.1
>
>         Attachments: sort-fields.diff, thrift-236.patch, 
> thrift-consistent-order-v2.patch, thrift-consistent-order-v3.patch, 
> thrift-consistent-order.patch
>
>
> As it stands right now, Ruby generated structs will be serialized in 
> arbitrary order (due to storage of metadata in a hash). This leads to 
> different binary encoding for the same struct values. Ideally, it should be 
> the same for any two serializations of equivalent structs, and between 
> languages if possible. 
> The two approaches that seem to make the most sense are in lowest-to-highest 
> field id order, and in IDL-defined order. What do people think of this idea, 
> and which approach would be preferred?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to