Committed. Thanks for the patch. FYI, this is probably due
to your glibc version, rather than gcc.
--David
Evan Klitzke wrote:
> I guess the mailing list ate my patch, included inline:
>
> diff --git a/compiler/cpp/src/parse/t_type.h
> b/compiler/cpp/src/parse/t_type.h
> index e7e459c..4ce2eda 100644
> --- a/compiler/cpp/src/parse/t_type.h
> +++ b/compiler/cpp/src/parse/t_type.h
> @@ -23,6 +23,7 @@
> #include <string>
> #include <map>
> #include <cstring>
> +#include <stdint.h>
> #include "t_doc.h"
>
> // What's worse? This, or making a src/parse/non_inlined.cc?
> diff --git a/lib/cpp/src/Thrift.h b/lib/cpp/src/Thrift.h
> index 83bef47..26d2b0f 100644
> --- a/lib/cpp/src/Thrift.h
> +++ b/lib/cpp/src/Thrift.h
> @@ -23,6 +23,7 @@
> #ifdef HAVE_CONFIG_H
> #include "config.h"
> #endif
> +#include <stdio.h>
>
> #include <netinet/in.h>
> #ifdef HAVE_INTTYPES_H
> diff --git a/lib/cpp/src/concurrency/Thread.h
> b/lib/cpp/src/concurrency/Thread.h
> index 6b9fc03..d4282ad 100644
> --- a/lib/cpp/src/concurrency/Thread.h
> +++ b/lib/cpp/src/concurrency/Thread.h
> @@ -20,6 +20,7 @@
> #ifndef _THRIFT_CONCURRENCY_THREAD_H_
> #define _THRIFT_CONCURRENCY_THREAD_H_ 1
>
> +#include <stdint.h>
> #include <boost/shared_ptr.hpp>
> #include <boost/weak_ptr.hpp>
>
> diff --git a/lib/cpp/src/protocol/TBase64Utils.h
> b/lib/cpp/src/protocol/TBase64Utils.h
> index e6b172a..3def733 100644
> --- a/lib/cpp/src/protocol/TBase64Utils.h
> +++ b/lib/cpp/src/protocol/TBase64Utils.h
> @@ -20,6 +20,7 @@
> #ifndef _THRIFT_PROTOCOL_TBASE64UTILS_H_
> #define _THRIFT_PROTOCOL_TBASE64UTILS_H_
>
> +#include <stdint.h>
> #include <string>
>
> namespace apache { namespace thrift { namespace protocol {
>
>
> On Tue, Mar 31, 2009 at 5:04 PM, Evan Klitzke <[email protected]> wrote:
>> I checked out HEAD from git.thrift-rpc.org today (commit
>> 66724ed566786fab6cf1d3c3371f317245d91564) and thrift wasn't building
>> for me due to some missing includes, mostly for stdint.h. The attached
>> patch made thrift buildable for me (this is on Fedora 11 beta/gcc
>> 4.4).
>>
>> Thanks.
>>
>> --
>> Evan Klitzke <[email protected]> :wq
>>
>
>
>
