[
https://issues.apache.org/jira/browse/THRIFT-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696699#action_12696699
]
Jonathan Ellis commented on THRIFT-339:
---------------------------------------
> I can be wrong, but Esteve's patch doesn't work with old generated code
I'm confused. The whole point of this ticket is so we can replace old, broken
generated code with generated code that works. If you are regenerating what is
there to not work with?
Personally I would be most comfortable to get Esteve's buy-in on whatever fix
we go with since he was the author of the -242 patch IIRC.
> THRIFT-242 is incompatible with arguments with empty key fields
> ---------------------------------------------------------------
>
> Key: THRIFT-339
> URL: https://issues.apache.org/jira/browse/THRIFT-339
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Python)
> Reporter: Jonathan Ellis
> Fix For: 0.1
>
> Attachments: default+neg-field.diff, thrift-339-2.patch,
> thrift-339-3.patch, thrift-339-4.patch, thrift-339-5.patch,
> thrift-339-6.patch, thrift-339.patch, thrift-python-defaults-v2.patch,
> thrift-python-defaults.patch
>
>
> Esteve's last change to how default values are stored broke stuff. Here is a
> quick example:
> {{
> service Test
> {
> bool get_slice(i32 start = -1),
> }
> }}
> generates
> {{
> class get_slice_args:
> thrift_spec = None
> def __init__(self, start=thrift_spec[-1][4],):
> self.start = start
> }}
> which is obviously invalid.
> I'm not sure how thrift_spec is supposed to be populated here so I'm unsure
> how to fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
