[
https://issues.apache.org/jira/browse/THRIFT-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698452#action_12698452
]
Bryan Duxbury commented on THRIFT-377:
--------------------------------------
Would it be possible for someone with an understanding of TFileTransport mind
telling me what its purpose is? It would seem that it's more than just a
transport, and some context would be useful.
Some comments on the current version of the patch:
* No @author tags are allowed in apache code
* Would be nice to have a class comment explaining the Event inner class
* chunkState inner class should be ChunkState; consider writing method defs
across multiple lines instead of all packed up on one line
* Should TSeekableFile be TSeekableTransport?
* Please move tests to a separate test file that lives under test/
> TFileTransport port in Java
> ---------------------------
>
> Key: THRIFT-377
> URL: https://issues.apache.org/jira/browse/THRIFT-377
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Java)
> Reporter: Joydeep Sen Sarma
> Attachments: 377.2.patch, thrift-377.patch.3
>
>
> there are environments in which data is being logged in TFileTransport
> (presumably C++ land) and data is desired to be consumed/imported into Hadoop.
> For this a Java version of TFileTransport is required. I am planning to post
> one that only reads the data - this code is already in use and tested and
> fulfils the current requirements.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
