I have found and, I believe, fixed a couple of crashing bugs in
ThreadManager::Impl. However, in order to see them happen I first
needed to modify lib/cpp/src/concurrency/test/Tests.cpp so it would
run the block test in a loop, then I had to fix all of the bugs in
ThreadManagerTests::blockTest. Before embarking on this adventure, I
had also added new tests of Mutex and RecursiveMutex (not a class,
just a way of instantiating a Mutex) to ThreadManagerTests.
So my question is this. How should I file the bugs? I already have
THRIFT-466 (https://issues.apache.org/jira/browse/THRIFT-466) in
against blockTest. I can file a bug against ThreadManager in the C++
Library section and include a patch with it that would make the
Tests.cpp run the blockTest in a loop. Do I also file a new bug
against ThreadManagerTests::blockTest that contains the fixes that are
required? How do I deal with the overlap between that new bug and
THRIFT-466? I could modify 466 it to have all of my changes, which
would supercede the previous patch. Would that work? (I assume that I
can just refer from the ThreadManager bug to the one for blockTest.)
And lastly, there are those new tests for Mutex and RecursiveMutex. Do
I separate them out from the other stuff and file a separate issue?
Any guidance?
Thanks,
Rush
