[
https://issues.apache.org/jira/browse/THRIFT-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729114#action_12729114
]
Esteve Fernandez commented on THRIFT-413:
-----------------------------------------
+1 This will make THRIFT-395 easier to solve.
> Type annotations for base types
> -------------------------------
>
> Key: THRIFT-413
> URL: https://issues.apache.org/jira/browse/THRIFT-413
> Project: Thrift
> Issue Type: Improvement
> Reporter: David Reiss
> Priority: Minor
> Attachments:
> 0001-THRIFT-413.-Suppport-for-annotations-on-base-types.patch
>
>
> This patch allows type annotations to be applied to base types. The one
> thing about it that scared me a bit was that we were allocating a new type
> object for each base type with annotations, so checks like
> {code}
> if (get_true_type(ttype) == g_type_i32)
> {code}
> would fail if ttype had annotations. But I grepped for all uses of the
> global type objects and didn't find anything like that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
