Cocoa code generator doesn't put keywords before all arguments.
---------------------------------------------------------------
Key: THRIFT-541
URL: https://issues.apache.org/jira/browse/THRIFT-541
Project: Thrift
Issue Type: Improvement
Components: Compiler (Cocoa)
Reporter: Matt Ronge
Priority: Minor
The compiler doesn't put keywords in front of all args. Per Cocoa coding
conventions
(http://developer.apple.com/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html#//apple_ref/doc/uid/20001282-1001751-BCIJHEDH)
all args should have a keyword.
Currently this would be generated
- (int32_t) calculate: (int32_t) logid : (Work *) w;
But this is better
- (int32_t) calculate: (int32_t) logid w: (Work *) w;
Attached is a very small patch that uses the name of the arg variable as the
keyword.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
