[
https://issues.apache.org/jira/browse/THRIFT-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757226#action_12757226
]
Esteve Fernandez commented on THRIFT-585:
-----------------------------------------
Mattias:
I think the standard blocking Python generator doesn't pass unexpected
exceptions from the server to the client (see TSimpleServer#server, it just
closes the transports). But it actually does, it's far better to override
ThriftServerProtocol#processError rather than adding stuff to the generator.
In any case, if you think the Twisted generator is behaving differently from
the blocking version, please file a different issue, if you have a fix for it,
attach a patch, not the entire source file. This helps us track issues more
effectively.
> exceptions in the autogenerated send_METHOD functions are not propagated
> (Twisted)
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-585
> URL: https://issues.apache.org/jira/browse/THRIFT-585
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Python), Library (Python)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: 585-handle-send-exceptions.patch, t_py_generator.cc
>
>
> If an error occurs in the autogenerated send_METHOD functions, the returned
> deferred is not notified and the caller can't manage the error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
