Use a Java enum to represent field ids in generated structs
-----------------------------------------------------------
Key: THRIFT-623
URL: https://issues.apache.org/jira/browse/THRIFT-623
Project: Thrift
Issue Type: Improvement
Components: Compiler (Java)
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
Fix For: 0.2
Attachments: thrift-623.patch
The way things work today, field IDs get constants in their structs, but all
the methods take ints as parameters when they actually want a field id. This is
not the best, since it can lead to accidentally putting in field ids that don't
exist, and we have to do extra work to make sure things behave correctly.
Instead, we should make the field IDs into a proper Java enum class, and make
the methods take that class as the parameter type. That way, we'll get the
compiler's help enforcing our use of only legal field IDs, plus easier
association with name info, docstrings, etc. All in all, it should amount to a
usability improvement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
