[ 
https://issues.apache.org/jira/browse/THRIFT-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury updated THRIFT-632:
---------------------------------

    Attachment: thrift-632-v6.patch

Here's an updated version of the patch. I made the organizational and stylistic 
changes suggested.

I'm not sure I understand your comment about ints and constants. Can you give 
me an example?

As you've noticed, this patch makes the values for enum constants "explicit" 
ahead of when it has been happening up to this point. That is, instead of the 
individual language generators deciding the values for "valueless" enum 
constants, now, they will be set during the grammar parsing phase. The values 
themselves should remain consistent.

> Constants of enum types don't behave well
> -----------------------------------------
>
>                 Key: THRIFT-632
>                 URL: https://issues.apache.org/jira/browse/THRIFT-632
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.2
>
>         Attachments: thrift-632-v2.patch, thrift-632-v3.patch, 
> thrift-632-v4.patch, thrift-632-v5.patch, thrift-632-v6.patch, 
> thrift-632.patch
>
>
> It turns out that THRIFT-551 missed the case of constants defined of enum 
> types. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to