What is the best way to merge a bunch of code from Facebook?
------------------------------------------------------------
Key: THRIFT-654
URL: https://issues.apache.org/jira/browse/THRIFT-654
Project: Thrift
Issue Type: Question
Components: Compiler (General), Library (C++), Library (Java),
Library (Python)
Reporter: David Reiss
Hey guys. I've been kind of lax porting patches developed at Facebook back
into the open-source repository, but I'm catching up now. I have a bunch of
Apache-ready patches at
http://gitweb.thrift-rpc.org/?p=thrift.git;a=shortlog;h=refs/heads/pri/dreiss/fb-merge-p1;hb=HEAD
(long view:
http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fb-merge-p1;hb=HEAD).
It's almost all C++ library changes, with some other misc stuff sprinkled in.
What do you guys think would be the best way of merging this stuff into
Apache? I'd prefer not to create a separate issue for each C++ patch,
especially since they've all been reviewed and production-tested internally. I
can do it for the non-C++ stuff if you'd like. Would people be okay if I just
create one big patch set for the C++ stuff, attach it here, and commit after a
week if there are no objections?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
