[
https://issues.apache.org/jira/browse/THRIFT-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838414#action_12838414
]
James Bathgate commented on THRIFT-717:
---------------------------------------
+1
> Global variables should not be used for configuration of PHP library
> --------------------------------------------------------------------
>
> Key: THRIFT-717
> URL: https://issues.apache.org/jira/browse/THRIFT-717
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Reporter: Nicholas Telford
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The Thrift PHP library makes gratuitous use of the $GLOBALS array to store
> basic configuration.
> Globals in PHP are generally bad practice, so I suggest something else: Use
> constants.
> Being immutable, constants are more secure than globals (that could be
> overwritten in scripts susceptible to injection attacks); they also perform
> much better, since the $GLOBALS variable is a hash-table, lookups are
> comparatively expensive.
> I will attach a patch soon unless anyone has any better ideas.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
