[
https://issues.apache.org/jira/browse/THRIFT-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838471#action_12838471
]
David Reiss commented on THRIFT-718:
------------------------------------
Your patch mixes LF and CRLF line endings. Please remove the CRs.
I just looked at two random packages from PEAR, and both had closing tags at
the end.
Also, I don't see any extraneous whitespace. Do you mean the newlines at
end-of-file? Those are supposed to be there.
> Thrift PHP library includes closing tags and extraneous whitespace
> ------------------------------------------------------------------
>
> Key: THRIFT-718
> URL: https://issues.apache.org/jira/browse/THRIFT-718
> Project: Thrift
> Issue Type: Improvement
> Components: Library (PHP)
> Reporter: Nicholas Telford
> Attachments: thrift_php_closingTags.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Extraneous whitespace after a PHP script's closing tag (?>) can cause big
> problems when sending headers to the client.
> It is generally advised that closing PHP tags be omitted from the end of a
> PHP file to prevent extraneous whitespace being an issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
