[
https://issues.apache.org/jira/browse/THRIFT-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Duxbury updated THRIFT-710:
---------------------------------
Attachment: thrift-710.patch
This patch makes TBinaryProtocol use direct buffer access in the relevant
methods. My performance testing was somewhat rudimentary, but I think it may
have as much as doubled performance. Obviously your performance boost will be
really dependent on the contents of your struct, but this seems pretty great.
As a side effect of this issue, I refactored the TCompactProtocol test so that
we could exact TBinaryProtocol to the same bevy of test cases.
> TBinaryProtocol should access buffers directly when possible
> ------------------------------------------------------------
>
> Key: THRIFT-710
> URL: https://issues.apache.org/jira/browse/THRIFT-710
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Java)
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-710.patch
>
>
> TBinaryProtocol can probably take even more advantage of direct buffer access
> than TCompactProtocol. Identify the relevant spots and clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
