[
https://issues.apache.org/jira/browse/THRIFT-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840495#action_12840495
]
Bryan Duxbury commented on THRIFT-723:
--------------------------------------
The reason I chose to consider Sets and Maps incomparable is because there is
no natural ordering to them. Lists are fundamentally ordered, making it obvious
how to compose their ordering into a larger ordering.
I'm not completely against adding this feature, but it does seem a bit
unnatural. The sort order of structs containing sets or maps would be somewhat
unintuitive, which is probably fine if you just want "some" consistent
ordering.
> Thrift buffers with set and map types in Java should implement Comparable
> -------------------------------------------------------------------------
>
> Key: THRIFT-723
> URL: https://issues.apache.org/jira/browse/THRIFT-723
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java), Library (Java)
> Reporter: Dmitry Chechik
> Attachments: thrift-compare-to.patch
>
>
> Currently, Thrift objects in Java don't implement Comparable if any field is
> a set or a map.
> The patch attached implements Comparable for those cases. If we can compare a
> List, we should be able to compare a Set just as easily. This implementation
> compares two thrift objects by comparing the sorted entries of each set or
> map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
