[
https://issues.apache.org/jira/browse/THRIFT-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845700#action_12845700
]
Bryan Duxbury commented on THRIFT-735:
--------------------------------------
I don't think it's that much of a can of worms. Imagine that instead of a union
type, the list contains enums, and you remove an enum value from the type.
Those values would be dropped silently. If a struct has a required field of
type enum and a value goes away, again, it will be treated as an unset field.
If this field was required, then it would not pass deserialization validation.
If you have a struct with a required field that's a union, you can add or
rename fields with impunity. If you remove a union field, and you can't get a
valid value in that struct field anymore, and you've marked the struct field as
required, then you've literally made any serialized data containing those
now-defunct values invalid. The exact same argument applies cleanly to
enumerated types.
> Required field checking is broken when the field type is a Union struct
> -----------------------------------------------------------------------
>
> Key: THRIFT-735
> URL: https://issues.apache.org/jira/browse/THRIFT-735
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java), Library (Java)
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-735.patch
>
>
> The validate() method on generated structs verifies that required fields are
> set after validation. However, if the type of the field is a Union struct,
> then just checking that the field isn't null is not a valid check. The value
> may be a non-null union, but have an unset field. (We encountered this when
> deserializing a type that had a union for a field, and the union's set value
> was an enum value that had been removed from the definition, making it a
> skip.)
> In order to perform the correct validation, if the value is a Union, then we
> must also check that the set field and value are non-null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
