[
https://issues.apache.org/jira/browse/THRIFT-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856849#action_12856849
]
Nicholas Telford commented on THRIFT-755:
-----------------------------------------
> Should there be parens around the right-hand size of the macro?
No idea, I'm not a C dev. I examined several other extensions and they all had
the same macro (obviously with a different module name) so it should be fine.
> Also, are you building with ZTS?
I don't know what ZTS is, but I don't think so since: "php -i | grep zts"
yeilds no output.
> PHP Extension Fails to compile [Patch]
> --------------------------------------
>
> Key: THRIFT-755
> URL: https://issues.apache.org/jira/browse/THRIFT-755
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Affects Versions: 0.2
> Environment: UNIX, PHP5
> Reporter: Nicholas Telford
> Priority: Minor
> Fix For: 0.2
>
> Attachments: php_thrift_protocol.h.diff
>
>
> The native PHP extension fails to compile at all due to a spelling error in
> php_thrift_protocol.h:
> extern zend_module_entry thrift_protocole_module_entry; <-- "protocole"!?
> Also, if this is fixed, it will only compile as a shared module. To compile
> as a static module, the following needs to be added to php_thrift_protocol.h:
> #define phpext_thrift_protocol_ptr &thrift_protocol_module_entry
> The attached patch is a solution to both problems, fixing compilation. I have
> tested and verified that it works.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
