[
https://issues.apache.org/jira/browse/THRIFT-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859795#action_12859795
]
James Grant commented on THRIFT-760:
------------------------------------
This change is only for the client. I have checked the server part of the
generator for C++, Python, C#, PHP and Java and they all correctly return the
seqid sent in the request.
This change only checks that value and throws an exception when they do not
match.
The current behavior will either fail with a protocol error or return an
incorrect result. Although the patch I supplied only applies to the Java client
I think the same change should be made to the other languages.
> Generated client code does not set or check the sequence ID in messages
> -----------------------------------------------------------------------
>
> Key: THRIFT-760
> URL: https://issues.apache.org/jira/browse/THRIFT-760
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Affects Versions: 0.2
> Reporter: James Grant
> Priority: Minor
> Attachments: thrift-seqid.patch
>
>
> The sequence ID is never set in the generated client code. It is also never
> checked. This means that if you continue to use a connection after a socket
> timeout the returned results can arrive out of sequence. When this happens an
> exception should be thrown so that incorrect results are never returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
