[
https://issues.apache.org/jira/browse/THRIFT-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861105#action_12861105
]
Bryan Duxbury commented on THRIFT-765:
--------------------------------------
We can't actually use the method that already exists on DataOutputStream,
because it wants to wrap a stream object, and implies a Java-specific frame
size that doesn't meet our needs.
I did not copy the implementation. I adapted the technique found in
DataOutputStream#writeUTF (and a similar version found in Kryo's
StringSerializer) to work with Thrift. I could include the license notice from
Kryo if you think that we could be in license trouble here.
> Improved string encoding and decoding performance
> -------------------------------------------------
>
> Key: THRIFT-765
> URL: https://issues.apache.org/jira/browse/THRIFT-765
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Java)
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-765.patch
>
>
> One of the most consistent time-consuming spots of Thrift serialization and
> deserialization is string encoding. For some inscrutable reason,
> String.getBytes("UTF-8") is slow.
> However, it's recently been brought to my attention that DataOutputStream's
> writeUTF method has a faster implementation of UTF-8 encoding and decoding.
> We should use this style of encoding.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
