[
https://issues.apache.org/jira/browse/THRIFT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871406#action_12871406
]
Bryan Duxbury commented on THRIFT-783:
--------------------------------------
Looks like you fixed this a long time ago:
{code}
[bryanduxbury thrift-svn-clean-1]$svn blame
compiler/cpp/src/generate/t_java_generator.cc | grep Arrays.equals
810300 bryanduxbury indent(out) << "
Arrays.equals((byte[])getFieldValue(), (byte[])other.getFieldValue()) :
getFieldValue().equals(other.getFieldValue()));" << endl;
665541 dreiss unequal = "!java.util.Arrays.equals(this." + name + ",
that." + name + ")";
{code}
> .equals java method is broken on structs containing binary-type fields
> ----------------------------------------------------------------------
>
> Key: THRIFT-783
> URL: https://issues.apache.org/jira/browse/THRIFT-783
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Jonathan Ellis
> Fix For: 0.4
>
>
> The generated code uses field1.equals(field2) (which is never the case except
> for the trivial one of field1==field2) instead of Arrays.equals(field1,
> field2).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
