> - should I attach this stuff to THRIFT-582 as a massive patch? not > sure how well that would work, as there will still be a lot of future > updates. I'm happy to just continue to work on github, or use something > else if there are suggestions. Yes, you should attach a massive patch, since that is the easiest way for us to document the history of the code. Keeping an active branch on github is also good to allow more detailed analysis of the development process.
> - GLib doesn't provide something that maps directly to Thrift Sets. I > used GHashTable to fake it, setting the key and the value to the set > member. I could subclass GHashTable and create something called TSet or > THashSet (or GSet or GHashSet?), or I could just continue with > GHashTable. Any thoughts? For PHP, we just set the key to the member and the value to 1. I think that any of the options you mentioned are fine. --David
