[
https://issues.apache.org/jira/browse/THRIFT-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier updated THRIFT-247:
-------------------------------
Attachment: THRIFT-247_THttpServer.v3.patch
I like that patch!
I did several tests with the tutorial.thrift using JSON and Binary protocol.
The new class THttpTransport is a good idea.
I did the following changes on the v2 patch:
- added Thrift version information to the HTTP headers via VERSION define
- add the original THttpClient Constructor again, for compatibility
- add correct Apache license headers
- @author tags removed
The patch is against:
Repository Root: http://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 950930
Thanks
Roger
> THttpServer Transport
> ---------------------
>
> Key: THRIFT-247
> URL: https://issues.apache.org/jira/browse/THRIFT-247
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Jérémie BORDIER
> Priority: Minor
> Attachments: THRIFT-247_THttpServer.patch,
> THRIFT-247_THttpServer.v2.patch, THRIFT-247_THttpServer.v3.patch
>
>
> Here is a first working version of the THttpServer transport for the C++
> library.
> It was inspired by Mark Slee's THttpClient which i splitted into an
> interface, THttpTransport and two transport implementations, THttpClient and
> THttpServer. Tested with TJsonProtocol (the fixed revision available in
> THRIFT-244) and TBinaryProtocol in the tutorial example, works like a charm.
> The code is available in the attached patch, and in the gitweb tree in
> refs/pri/jbordier/cleaning_protocols, or also in github:
> http://github.com/ahfeel/thrift/tree/master
> It only supports POST requests yet, and i'm working in adding a
> ?callback=some_js_callback support to the URI to have JsonP protocol support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
