On Wed, 2010-06-09 at 07:52 -0700, Bryan Duxbury wrote: > On Wed, Jun 9, 2010 at 12:13 AM, Upayavira <u...@odoko.co.uk> wrote: > > > Bryan - thanks for doing this - it looks like it was a lot of work! > > > > I have looked through this to the best of my abilities - principally by > > comparing against version 0.2.0. > > > > I apologise for my delay in doing so. > > > > Here's some things I notice: > > * there are no release notes relating to this release in the NEWS > > file. In fact, the notes about 0.2.0 have gone. It seems that the > > 0.2.0 release notes were generated from Jira, which makes sense. > > * I presume these files have no license header because they are > > auto-generated? > > compiler/cpp/thriftl.cc > > compiler/cpp/thrifty.cc > > compiler/cpp/thrifty.h > > compiler/cpp/version.h.in > > > > Correct - autogenerated. > > > > * Again, these file lacks a header, but don't look autogenerated: > > lib/java/src/org/apache/thrift/transport: TMemoryInputTransport.java > > lib/java/test/org/apache/thrift/TestStruct.java > > lib/java/test/org/apache/thrift/TestTBaseHelper.java > > lib/java/test/org/apache/thrift/TestTUnion.java > > > > lib/java/test/org/apache/thrift/transport/TestTMemoryInputTransport.java > > lib/js/test/src/test/TestHandler.java > > lib/py/src/TSerialization.py > > > > Yeah, I think these are erroneously unlicensed. I'll get that fixed. Is this > enough to torpedo the release candidate?
Sorry for my delay once more. I'm afraid these are enough to derail this RC. Can you tweak and roll another (and include sebb's concerns from gene...@incubator too). Then I'll promise to be more responsive to your next vote! (feel free to alert me privately to the start of a vote in case I don't notice it immediately on the dev list). Upayavira
