[
https://issues.apache.org/jira/browse/THRIFT-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880675#action_12880675
]
Jordan commented on THRIFT-550:
-------------------------------
Roger,
I took a look at that. Thank you. I did mention in that Jira item that my
operation returns a boolean, not void and not i32, and I asked you in that jira
task if your patch will fix that as well. If you could, could you please answer
that question in that jira task thread? Thank you.
Also, supposing that exceptions ARE indeed thrown correctly. What happens with
a runtime exception? What do you think SHOULD happen with a runtime exception.
It seems from the service side, we should never let an unchecked exception be
thrown back to the client. In the java generated code, it masks them as
TApplicationException, which is good, but can you verify that the way it does
that is broken? Look at an operation that does not *declare* an exception.
Notice how it does not catch throwable and transform to TApplicationException.
Granted, I think it's wise to declare that *all* of your operations throw
YourMadeUpServiceException.
> JavaScript language target
> --------------------------
>
> Key: THRIFT-550
> URL: https://issues.apache.org/jira/browse/THRIFT-550
> Project: Thrift
> Issue Type: New Feature
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Fix For: 0.3
>
> Attachments: THRIFT-550_initialize_with_null.patch, thrift_js.patch,
> thrift_js_v2.patch, thrift_js_v3.patch
>
>
> This allows javascript clients to be built for browser based access to thrift
> services.
> The supported transport is XHTTPRequest and the supported Protocol is
> compatible with TJSONProtocol
> I've added a test in lib/js that is a java based HTTP server which implements
> ThriftTest service.
> I've put a version of this test service here
> http://3.rdrail.net:8080/test/test.html if you'd like to see it in action.
> It's been tested in ie 6,7,8, FF, and Safari.
> Let me know if you hit any issues. The protocol and transport code aren't
> very error tolerant, but overall it seems to work quite well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
