[ 
https://issues.apache.org/jira/browse/THRIFT-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891651#action_12891651
 ] 

Wil Tan commented on THRIFT-492:
--------------------------------

Please ignore the attached patch, I've updated it to work with trunk. It's on 
my github fork of David's repos here: 
http://github.com/wil/thrift/commit/103cee455456b5728e981f7dd4088edb366dfa40

Could someone please advise how I could help to get this merged into the 
official code base?

IMO it's quite an important issue as the default 5 seconds timeout is too 
restrictive for many use cases.

Thanks!

> Add Timeout Argument to thrift_client:call()
> --------------------------------------------
>
>                 Key: THRIFT-492
>                 URL: https://issues.apache.org/jira/browse/THRIFT-492
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Erlang)
>         Environment: N/A
>            Reporter: Wil Tan
>            Priority: Minor
>         Attachments: thrift_client-v2.diff
>
>
> thrift_client:call() does not use a timeout option when calling 
> gen_server:call(), so the default timeout of 5 seconds is used. It would be 
> good to offer that to the user of the module.
> The attached trivial patch does exports a new function call/4 which does 
> this, and makes the original call/3 function pass in the default 5000 ms 
> timeout value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to