Please address the comments on the ticket and one of the committers (probably me) will take care of it.
On Thu, Aug 5, 2010 at 10:43 AM, Steven Ong <[email protected]> wrote: > How can I commit it? > > Thanks, > Steven > > On Thu, Aug 5, 2010 at 11:47 AM, Bryan Duxbury <[email protected]> wrote: > > > That ticket hasn't been committed, and it's slated for inclusion in > Thrift > > 0.4. > > > > On Thu, Aug 5, 2010 at 9:02 AM, Steven Ong <[email protected]> > > wrote: > > > > > It's still failed to build on cygwin (See JIRA THRIFT-757) > > > > > > On Wed, Aug 4, 2010 at 2:35 PM, Mark Slee <[email protected]> wrote: > > > > > > > Awesome! Guess all that's left is to stick it in SVN and update the > > > > download page. > > > > > > > > -----Original Message----- > > > > From: Bryan Duxbury [mailto:[email protected]] > > > > Sent: Wednesday, August 04, 2010 11:56 AM > > > > To: [email protected] > > > > Subject: Re: Thrift 0.3.0 RC6 > > > > > > > > We have > 3 +1 votes from Thrift users and devs, 3 +1 votes from the > > > > Incubator PMC, and no -1 votes. The vote has been open for a good > long > > > > time, > > > > so I believe that it has passed. > > > > > > > > On Mon, Aug 2, 2010 at 6:04 PM, Igor Ribeiro de Assis > > > > <[email protected]>wrote: > > > > > > > > > +1 > > > > > > > > > > But could not find the public key to check with GPG. > > > > > > > > > > On Wed, Jul 28, 2010 at 12:28 PM, Bryan Duxbury <[email protected] > > > > > > wrote: > > > > > > All, > > > > > > > > > > > > RC5 went out to gene...@incubator and met some resistance. I've > > make > > > > > fixes > > > > > > to the branch and I believe we're ready to go again. > > > > > > > > > > > > I propose we accept RC6 as the official version of Thrift 0.3.0. > > > > > > > > > > > > You can find the tarball at > > > > > > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc6.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz> > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz> > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz> > > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz> > > > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz> > > > > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz > >, > > > > > > which was created by checking out > > > > > > > https://svn.apache.org/repos/asf/incubator/thrift/branches/0.3.xand > > > > > running > > > > > > "make dist". > > > > > > > > > > > > The GPG signature can be found at > > > > > > > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc6.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.asc> > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.asc> > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.asc> > > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.asc> > > > > < > http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.asc> > > > > > < > > http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.asc> > > > > > > . > > > > > > > > > > > > The md5 summ is a6c80ab3d8c7827365a9b40f5c9d66a3, which can also > be > > > > found > > > > > at > > > > > > > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc6.tar.gz.md5<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.md5> > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.md5> > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.md5> > > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.md5> > > > > < > http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.md5> > > > > > < > > http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.md5> > > > > > > . > > > > > > > > > > > > The sha1 summ is 671e6913c86dbac5a7c84a82d94045b3649d38f1, which > > can > > > > also > > > > > be > > > > > > found at > > > > > > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc6.tar.gz.sha1<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.sha1> > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.sha1> > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.sha1> > > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.sha1 > > > > > > < > http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.sha1 > > > > > > > > < > > http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc6.tar.gz.sha1 > > > > > > > > > > . > > > > > > > > > > > > Please download, verify signatures and summs, untar, and install > > the > > > > > > libraries of your choice. > > > > > > > > > > > > -Bryan > > > > > > > > > > > > Note: I spent some time looking at this release with RAT, and > while > > > it > > > > > still > > > > > > produces some warnings, that is because of my inability to figure > > out > > > > how > > > > > to > > > > > > make it exclude the things it complains about. Please refer to > the > > > > > LICENSE > > > > > > file for information on files with ambiguous licenses. > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Igor Ribeiro de Assis > > > > > > > > > > > > > > >
