[
https://issues.apache.org/jira/browse/THRIFT-815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier updated THRIFT-815:
-------------------------------
Attachment: THRIFT_815_TestFramework_test.html_json2.patch
I have the Java Test Server up and running! => The current trunk version passes
the tests!
see: http://www.bufferoverflow.ch:8088/test/test.orig.html
As mentioned I added a few additional Tests, see
http://www.bufferoverflow.ch:8088/test/test.html
The patch(THRIFT_815_TestFramework_test.html_json2.patch) contains additional
tests, adds the Apache License Header to test.html again and adds json2 which
is Public Domain.
I absolutely agree, that implementing Thrift JSON Protocol based on string
parsing is not that efficient as the eval approach.
However, during my debug and bug fixing (list element order on wire) sessions I
was often confused by the values of rstack and rpos inside thrift.js,
especially with map and mapmap objects. That's why I'm thinking about a classic
string parsing approach.
> Deserialization of lists is critically broken.
> ----------------------------------------------
>
> Key: THRIFT-815
> URL: https://issues.apache.org/jira/browse/THRIFT-815
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (JavaScript)
> Affects Versions: 0.4
> Reporter: Jordan
> Assignee: T Jake Luciani
> Priority: Blocker
> Fix For: 0.4
>
> Attachments: 813-1.patch, test.html, THRIFT-815_thrift.js.patch,
> THRIFT_815_TestFramework_test.html_json2.patch
>
>
> Edit the test code that comes with the js language target:
> var list = [1,2,3];
> var ret = client.testList(list);
> debugger;
> ret comes back as [3,3,3] when it should be echoed back as [1,2,3]
> The test case never caught this because it only verified the size, and not
> the contents of the returned array.
> I cannot find an immediate workaround, but I will try wrapping it in a dummy
> type like ListServiceResponse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
