[
https://issues.apache.org/jira/browse/THRIFT-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897991#action_12897991
]
Thomas Kho commented on THRIFT-837:
-----------------------------------
Sorry about that Bryan. Sloppiness on my part. Fixed and updated the patch.
What kind of format are you looking for regarding test case? I'm not really
sure how to write a programatic test for this, but there's not much to the
thrift definition I used to tickle the bug:
test.thrift:
struct TestRequest {
1: string request,
}
struct TestResponse {
1: string response,
}
service TestService {
TestResponse get(1: TestRequest request)
}
I used some Facebook-specific libraries for both the PHP client and C++ server.
The only salient notes are that I used a buffered transport and the accelerator
(TBinaryProtocolAccelerated).
> PHP accelerator bug for writes > 8k
> -----------------------------------
>
> Key: THRIFT-837
> URL: https://issues.apache.org/jira/browse/THRIFT-837
> Project: Thrift
> Issue Type: Bug
> Components: Library (PHP)
> Affects Versions: 0.1, 0.2, 0.3, 0.4
> Reporter: Thomas Kho
> Fix For: 0.4
>
> Attachments: php_extension_8kbug.patch
>
>
> When we write more than 8k, the output transport does a directWrite() rather
> than buffering, in which case we need to use the passed len value rather than
> the length of the buffer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
