[
https://issues.apache.org/jira/browse/THRIFT-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898383#action_12898383
]
David Reiss commented on THRIFT-819:
------------------------------------
I think it wold be better to just put these enums in your test code. It is
possible (easy, in fact) to have protocol, transport, and server types defined
outside of Thrift, so trying to catalogue them all within Thrift would be an
uphill battle. Synchronizing between languages is also tricky because not all
types exist in all languages. For example, Erlang has no nonblocking server
because blocking I/O is implemented efficiently in Erlang. It does, however,
have a disklog transport that uses a format provided by the Erlang standard
library. Java has no buffered transport because it is preferable to just wrap
a buffered stream around a socket.
> add Enumeration for protocol, transport and server types
> --------------------------------------------------------
>
> Key: THRIFT-819
> URL: https://issues.apache.org/jira/browse/THRIFT-819
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: Roger Meier
> Priority: Minor
> Attachments: THRIFT-819.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> I would like to have Enumeration's for protocol, transport and server types.
> I'm doing some testing stuff, and using types for the different parameter's
> would make it much more comfortable to work with, e.g.
> {code}
> // Dispatcher
> shared_ptr<TProtocolFactory> protocolFactory;
> if (protocol_type == PROTOCOL_JSON) {
> shared_ptr<TProtocolFactory> jsonProtocolFactory(new
> TJSONProtocolFactory());
> protocolFactory = jsonProtocolFactory;
> } else
> {
> shared_ptr<TProtocolFactory> binaryProtocolFactory(new
> TBinaryProtocolFactory());
> protocolFactory = binaryProtocolFactory;
> }
> {code}
> aligning these enums across all languages might be another benefit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
