[
https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906027#action_12906027
]
Ivan Murashko commented on THRIFT-705:
--------------------------------------
It has not to break HAVE_INTTYPES. The define will be recognized in a cpp file
because each cpp have config.h include before any others.
BTW: Typical usage of the header is in fprintf like expressions. I run a simple
grep and could not find any real usage of the header. Could you correct me if I
am wrong
> Installed C++ header files depend on "config.h" which may have conflicting
> macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r991496.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated
> system specific 'config.h' header file. Unfortunately, having this header
> file as a part of the library headers is generally troublesome. For example,
> see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on
> AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name
> and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++
> applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
