[
https://issues.apache.org/jira/browse/THRIFT-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907431#action_12907431
]
Bryan Duxbury commented on THRIFT-888:
--------------------------------------
I think this generally looks pretty good. A few comments:
The indentation in TAsyncClientManager$SelectThread.run is a little funky.
If we're going to put a finally block in TNonblockingServer's run method, we
should probably at least log whatever gets thrown - I hate silent catches.
If you have concerns about the code quality in the test, I think you'd better
just go ahead fix it. Realistically, if you leave it the way it is, it's not
going to get changed by anyone else in the foreseeable future.
> async client should also have nonblocking connect
> -------------------------------------------------
>
> Key: THRIFT-888
> URL: https://issues.apache.org/jira/browse/THRIFT-888
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.4, 0.5
> Reporter: Eric Jensen
> Fix For: 0.5
>
> Attachments: async_connect_final.diff
>
>
> or its purpose of avoiding thread pooling around blocking I/O is defeated.
> this was discussed briefly in the comments of
> https://issues.apache.org/jira/browse/THRIFT-862 and will most likely obviate
> https://issues.apache.org/jira/browse/THRIFT-843
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
