[
https://issues.apache.org/jira/browse/THRIFT-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908045#action_12908045
]
Bryan Duxbury commented on THRIFT-896:
--------------------------------------
This patch looks pretty good. Is there some reason why you made the socket
address package-private instead of the original private?
> TNonblockingSocket.isOpen() returns true even after close()
> -----------------------------------------------------------
>
> Key: THRIFT-896
> URL: https://issues.apache.org/jira/browse/THRIFT-896
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.4, 0.5
> Reporter: Eric Jensen
> Assignee: Bryan Duxbury
> Priority: Critical
> Fix For: 0.5
>
> Attachments: fix_nonblock_sock_isopen.diff
>
>
> SocketChannel.isConnected() has this broken behavior
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6341625, but TSocket
> corrects it by setting its Socket to null in close() and then checking that
> in isOpen(). This patch does something similar by checking
> SocketChannel.isOpen() which has the correct semantics. Added an assertion
> that exposed the previous failure. Also remove reference to derived Socket
> since it just confused matters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
