Ruby read timeouts can sometimes be 2x what they should be
-----------------------------------------------------------
Key: THRIFT-899
URL: https://issues.apache.org/jira/browse/THRIFT-899
Project: Thrift
Issue Type: Bug
Components: Ruby - Library
Affects Versions: 0.4, 0.3, 0.2, 0.1
Reporter: Ryan King
Thrift::Socket#read will sometimes fail to enforce a timeout properly and wait
approximately 2x @timeout before timing out the request.
Our testing via thrift_client (http://github.com/fauna/thrift_client) would
only fail about 1/20 of the time. My hypothesis is that it only fails when you
have a floating-point rounding error (we set the timeout to 0.8 seconds, but
the math gave us 0.7999, so we wait another 0.8 seconds).
The patch doesn't have any tests, because this problem is non-deterministic.
(also, I couldn't figure out how to run the tests)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
