[
https://issues.apache.org/jira/browse/THRIFT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913689#action_12913689
]
David Reiss commented on THRIFT-900:
------------------------------------
> I think the constructor of a socket is mostly hard coded, so the risk for a
> unlink("/etc/passwd") is very low.
"very low" isn't really good enough, IMO. I think having Thrift unlink files
that it didn't create would be very rude to programs that use the library. I
consider it a surprising and potentially dangerous behavior. Even if the risk
is low, I think the potential damage is too great.
> What are your thought's about a RFC 3986 compliant URI parser and passing
> such a URI to the constructor? e.g.
I think it would be fine as a utility library so that we don't have to
introduce a dependency on an external library just for this non-essential
feature. Something like socket(UriSocket::newFromUri("tcp://whatever").
I'm not sure what you mean by local functions.
> Unix domain socket
> ------------------
>
> Key: THRIFT-900
> URL: https://issues.apache.org/jira/browse/THRIFT-900
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Library
> Environment: Debian GNU/Linux Lenny
> Reporter: Roger Meier
> Fix For: 0.5
>
> Attachments: THRIFT-900_UnixDomainSockets.v2.patch,
> THRIFT-900_UnixDominSockets.patch
>
>
> I would like to use Unix domain sockets.
> client side:
> {code}
> shared_ptr<TSocket> socket(new TSocket("/tmp/ThriftTest.binary.thrift"));
> // as alternative to
> shared_ptr<TSocket> socket(new TSocket(host, port));
> {code}
> server side:
> {code}
> shared_ptr<TServerSocket> serverSocket(new
> TServerSocket("/tmp/ThriftTest.binary.thrift"));
> // as alternative to
> shared_ptr<TServerSocket> serverSocket(new TServerSocket(port));
> {code}
> further enhancement might be:
> use a RFC 3986 compliant URI parser e.g. by using
> http://uriparser.sourceforge.net/ (BSD License)
> and pass a real URI to the constructor, e.g.
> file:///tmp/ThriftTest.binary.thrift
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
