[
https://issues.apache.org/jira/browse/THRIFT-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918570#action_12918570
]
Bryan Duxbury commented on THRIFT-946:
--------------------------------------
This version looks better, but I'd really love it if you added a testcase to
TestStruct.testMetaData...
> Augment FieldValueMetaData so it differentiates 'string' and 'binary' fields.
> -----------------------------------------------------------------------------
>
> Key: THRIFT-946
> URL: https://issues.apache.org/jira/browse/THRIFT-946
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler, Java - Library
> Affects Versions: 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7
> Reporter: Mathias Herberts
> Priority: Minor
> Attachments: THRIFT-946.patch, THRIFT-946.patch-2
>
>
> String fields are not differentiated from binary fields in the meta data map.
> This is sometimes problematic when manipulating Thrift structs in tools such
> as Pig.
> The included patch extends FieldValueMetaData with 'isBinary' field and
> method and modifies the java compiler so generated code correctly reflects
> the binary nature of fields in the meta data.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
