[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Lavoie updated THRIFT-916:
------------------------------------
Attachment: v2-fix-all-warnings.patch
I don't think the two "declaration class $SOMETHING does not declare anything"
were related to my previous patch, but here's a common patch that fixes all
warnings in the C++ code when running with {{-Wall}} (with the exception of
{{thriftl.cc}}, which I'm still ignoring for now).
This has been tested on 64 bit Mac OS X 10.6, 32 bit Debian testing (gcc 4.4,
boost 1.42) and 64 bit Debian testing (gcc 4.4, boost 1.42). No warnings, apart
the flex output.
If it doesn't work for you, please include the output of:
{noformat}
uname -a ; cat /etc/debian_release ; dpkg --list | grep -i libboost ; g++
--version
{noformat}
So I can try to reproduce locally.
> gcc warnings in c++ header files
> --------------------------------
>
> Key: THRIFT-916
> URL: https://issues.apache.org/jira/browse/THRIFT-916
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.4
> Reporter: Piotr Bartosiewicz
> Assignee: Roger Meier
> Attachments: make-k.log, THRIFT-916_Wall_pedantic__noerrors.patch,
> v1-fix-format-strings.patch, v1-fix-java-style-and-warnings.patch,
> v1-fix-random-silly-warnings.patch, v2-fix-all-warnings.patch
>
>
> I tried to add an extra gcc warning options in my project but a number of
> warnings was emmited from thrift headers.
> Following the boost library recommendations, code should be clean with "-Wall
> -Wextra -pedantic" options.
> Currently only with -Wall thrift has no warnings.
> Other options worth considering (but require more work) are -Wconversion
> -Wold-style-cast
> So the task is to improve the thrift headers.
> I suggest also update all the thrift makefiles so the thrift sources an tests
> will indicate the faulty code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
