Hi Todd, A couple comments on your setup, you have a comment in the lib/java/Makefile.am file referring to ant, you probably mean maven. Also, should we try to derive the thrift version from configure? This would involve making the pom.xml a pom.xml.in and substiting. Having multiple versions to deal with in different places is a bit of a chore (maybe the version can be left out and added as a command line switch?).
Otherwise looks good to me. -Anthony On Sat, Sep 11, 2010 at 11:34:29PM -0700, Todd Lipcon wrote: > Hi Bjorn, > > I actually spent some time on this same task last weekend, though didn't get > far enough that I thought it was worth emailing the list. If you want to see > what I did and compare to yours, you can find it here: > > http://github.com/toddlipcon/thrift/tree/mvn > > Thanks > -Todd > > On Sat, Sep 11, 2010 at 5:05 PM, Bjorn Borud <[email protected]> wrote: > > > > > hi, > > > > given the problems with getting libthrift into the Maven Central > > repositories I figured I'd see if I can lend a hand, so I started > > reading up on what is needed to deploy artifacts into the Maven central > > repositories. > > > > it would seem that it would be easier to make this work if libthrift was > > built using Maven (the signing, deployment etc). Mostly because Ivy is > > sort of the ugly step-child of Maven so fewer people seem to be able to > > help out. (Not that Maven is much of a looker, mind you :-). > > > > so I started hacking a bit to convert the build to Maven to see what it > > takes. > > > > first I reorganized the sources to fit the Maven model (moving src into > > src/main/java, and test into src/test/java etc). then I modified > > build.xml so it will find the sources and tests and build. > > > > right now I am looking at fixing the unit tests so that they will run > > under Maven, but at this point I am unsure how much hassle it would be > > to make them work both with Ant and Maven. > > > > before I spend more time on this, would it be interesting to move from > > Ant to Maven? > > > > my primary motivation for doing this was to see what I could do to help > > with getting Thrift into the Maven Central repositories. > > > > -Bjørn > > > > > > > -- > Todd Lipcon > Software Engineer, Cloudera -- ------------------------------------------------------------------------ Anthony Molinaro <[email protected]>
